-
Notifications
You must be signed in to change notification settings - Fork 54
Module 2 and 3 Typos #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module 2 and 3 Typos #147
Conversation
Syncing fork with master
Module 2 Understanding the Modulo Operator, Reading Comprehension Solutions
CHANGE FROM:
If `n` is an integer, then 2 will divide into it evenly, and thus there is no remainder.
CHANGE TO:
If `n` is an even integer, then 2 will divide into it evenly, and thus there is no remainder.
Module 2 Data Structures (Part II): Dictionaries, Reading Comprehension Solutions
CHANGE FROM:
>>> get_maxes(dict(a=1, b=2,c= 2, d=1))
CHANGE TO:
>>> get_maxes(dict(a=1, b=2, c=2, d=1))
Module 3
Fixed links from "docs.scipy.org/doc/numpy/" to "numpy.org/doc/stable/"
Module 3 "Vectorized" Operations, Reading Comprehension Solutions
CHANGE FROM:
# top-left top-right bottom-left bottom-right
>>> x[:2, :2] + x[:2, -2:] + x[-2:, :2] + x[-2:, -2:]
array([[20, 24],
[36, 40]])
CHANGE TO:
# top-left top-right bottom-left bottom-right
>>> np.array([[np.sum(x[:2, :2]), np.sum(x[:2, 2:])], [np.sum(x[2:, :2]), np.sum(x[2:, 2:])]])
array([[10, 18],
[42, 50]])
Module 3 "Vectorized" Operations, Reading Comprehension: Basic Sequential Functions
CHANGE FROM:
Thus a (32,32,3) array would be a 32x32 RBG image.
CHANGE TO:
Thus a (32,32,3) array would be a 32x32 RGB image.
Module 3 Array Broadcasting, Reading Comprehension Solutions
MOVE "Broadcast Compatibility: Solution" section to BEFORE "Basic Broadcasting: Solution"
ADD <!-- #region --> and <!-- #endregion --> to moved section
Module 3 Array Broadcasting, Reading Comprehension: Basic Broadcasting III
CHANGE FROM:
Thus a (32,32,3) array would be a 32x32 RBG image.
CHANGE TO:
Thus a (32,32,3) array would be a 32x32 RGB image.
Module 3 Introduction to Basic and Advanced Indexing: Reading Comprehension: Ellipsis
QUESTION ABOUT:
Given a N-dimensional array, x, index into x such that you axis entry-0 of axis-0
QUESTION:
"such that you axis"? Should it be "such that you access"?
Module 3 Introduction to Basic and Advanced Indexing: Reading Comprehension Augmenting Array Data In-Place
IN:
>>> np.log(x[1:3], out=x[1:3])
>>> y += 3
REMOVE: (duplicate from rsokl#4, not relevant and not in solution)
>>> y += 3
Module 3 Introduction to Basic and Advanced Indexing: Reading Comprehension Augmenting Array Data In-Place
IN rsokl#7:
CHANGE FROM:
>>> y = y + 2
CHANGE TO (match answer key, and is already same question #3 asks):
>>> x = np.square(x)
Module 3 Introduction to Basic and Advanced Indexing: Reading Comprehension Augmenting Array Data In-Place
AFTER rsokl#9, APPEND:
```python
>>> np.square(y, out=y)
```
(answer is in Solutions, problem is missing)
Module 3 Introduction to Basic and Advanced Indexing: Reading Comprehension Solutions: Assignment via advanced indexing
Problem does not match solution.
CHANGE FROM:
Replace the diagonal elements of `x` with `(-1, -2, -3, -4)`, and add `1` to all values in `x` that are greater than `0.8`.
CHANGE TO:
Replace the diagonal elements of `x` with `(0, 1, 2, 3)`, and add `1` to all values in `x` that are greater than `0.8`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(whoops one of my suggested changes didn't go through)
rsokl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for these great revisions! This is fantastic. Just one correction with the update to the sum-of-quadrants revision.
Also, please feel free to add yourself to the list of contributors under Python/index.rst and Python/intro.rst 😄
Co-Authored-By: Ryan Soklaski <ryan.soklaski@gmail.com>
|
@ArtichokeSap If you are all finished, I'll go ahead and merge |
|
I think that’s everything! |
|
🎉 |
Changes to fix typos as detailed in Issue #146.